Skip to content

Fix Unity NotImplementedException error#22902

Merged
pakrym merged 2 commits intoAzure:mainfrom
daiyk:main
Jul 27, 2021
Merged

Fix Unity NotImplementedException error#22902
pakrym merged 2 commits intoAzure:mainfrom
daiyk:main

Conversation

@daiyk
Copy link
Copy Markdown
Contributor

@daiyk daiyk commented Jul 27, 2021

fix #22901

@ghost ghost added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 27, 2021
@ghost
Copy link
Copy Markdown

ghost commented Jul 27, 2021

Thank you for your contribution @daiyk! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Jul 27, 2021
@pakrym
Copy link
Copy Markdown
Contributor

pakrym commented Jul 27, 2021

Thank you for the verification. Let's keep both exception types in the catch() just in case.

@daiyk
Copy link
Copy Markdown
Contributor Author

daiyk commented Jul 27, 2021

Thank you for the verification. Let's keep both exception types in the catch() just in case.

Updated with catch NotSupportedException

@pakrym pakrym enabled auto-merge (squash) July 27, 2021 20:57
@pakrym
Copy link
Copy Markdown
Contributor

pakrym commented Jul 27, 2021

@daiyk, you might need to sign the CLA (https://cla.opensource.microsoft.com/)

@daiyk
Copy link
Copy Markdown
Contributor Author

daiyk commented Jul 27, 2021

@daiyk, you might need to sign the CLA (https://cla.opensource.microsoft.com/)

Hi, I have authorized Microsoft CLA to access my account on that page, seems doesn't work?

@pakrym pakrym closed this Jul 27, 2021
auto-merge was automatically disabled July 27, 2021 21:49

Pull request was closed

@pakrym pakrym reopened this Jul 27, 2021
@pakrym
Copy link
Copy Markdown
Contributor

pakrym commented Jul 27, 2021

Thank you, @daiyk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The latest change for Azure.Core doesn't fix the bug in Unity

2 participants